New grid view property migrators, migrate column settings from grid to block grid #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new settings migrators for:
The radio button list requires a new data type, so it's more complex than the others. The grid allows labels and values in a radio button list setting to be different, but that's not possible in a standard Umbraco radio button list, so I'm only keeping the labels. You'd need to add some code to convert from labels to values before outputting in a view.
Also added migration of column settings from grid to block grid. There's no way to add settings to a block grid area, so if there are settings present on a column they are added to a a "Settings container" layout, then the child controls go in that.