Update AMDGPU test #753
Closed
Update AMDGPU test #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
As a general remark working with Git and GitHub, opening a PR from a branch with the same name as the target branch is an anti-pattern. You should always create a new branch. This is the reason why the history of this PR has completely unrelated commits, which make review confusing. |
Closing this in favour of #754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify sync function.
Other infos:
Given the ☝️, tests should rather only support AMDGPU >= 0.5 and Julia 1.9. For MPI.jl, I don't know how to handle it. I'd lean towards restricting the usage of AMDGPU Ext to Julia 1.9, AMDGPU 0.5...