Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing get/set MPI.File info functions #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakebolewski
Copy link
Member

No description provided.

src/io.jl Outdated Show resolved Hide resolved
@simonbyrne
Copy link
Member

Also looks like you pushed this to master already? I'll revert that for now.

@jakebolewski
Copy link
Member Author

Whoops, that was a mistake. It seems like openmpi doesn't fill in the tested reserved kwargs by default as well.

@jakebolewski jakebolewski force-pushed the jcb/file_info branch 2 times, most recently from 7fe9e74 to 74d2d6e Compare September 4, 2020 20:05
src/io.jl Show resolved Hide resolved
@jakebolewski jakebolewski force-pushed the jcb/file_info branch 3 times, most recently from 8833317 to 0b618c3 Compare September 4, 2020 21:56
@test length(keys(fh_info)) == 0

# Test that default info hints on mpi-io implementation are present
@test parse(Int, fh_info[:coll_write_bufsize]) > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@jakebolewski jakebolewski Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i need to play around with OpenMPI's MPI IO implementation some more to understand what the defaults are across different versions. The CI build also doesn't seem to preserve valid file hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants