Make some constructors bold in stacktraces #40264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
approved these changes
Mar 30, 2021
simeonschaub
added
backport 1.6
KristofferC
pushed a commit
that referenced
this pull request
Apr 4, 2021
(cherry picked from commit 42766ac)
KristofferC
pushed a commit
that referenced
this pull request
Apr 4, 2021
(cherry picked from commit 42766ac)
KristofferC
pushed a commit
that referenced
this pull request
Apr 4, 2021
(cherry picked from commit 42766ac)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 42766ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 1.6 stack trace printing, some constructors aren't printed in bold, unlike most function names.
The problem can be seen with
Matrix{Int}([1 2; 3 4.5])from here: #37773 (comment), orusing DataFrames; DataFrame(1 => 2)from here: #40228 (with pictures).This should be a minimal repair. I believe it ought not to change any other behaviour.