Tweak stacktrace printing to increase prominence of filename:line info

[nickrobinson251]

Closes #40228

I think this would be a good resolution to #40228, but there are other options e.g. we could instead increase the configurability of printing, which we could discuss in #40228. Opening this to give us a concrete option (which i hope will be a minimally invasive one and help us avoid an extensive bikeshedding as i appreciate that a lot of thought has already gone into this).

This changes the display of the ~/path/to/filename:line from filename:line being underlined in :light_black to be displayed in the :normal color, thereby still giving it more importance that the rest of the filepath, while (hopefully) making it easier to read, and simplifying the UI by reducing the number of different grey-styles we have (from 4 to 3).

Dark theme example

Before

After

Light Theme example

Before

After

[KristofferC]

FWIW, I think the current formatting should stay as the default for a while at least. With every cosmetic change, it takes a while for the brain to get used to it and until that has happened you can't really evaluate it fairly.

Personally, I find it easier to find the file name with the current formatting than the suggested one here because it is the only thing that is underlined. With the suggested printing here, the types in the arguments and the file name have the same formatting so they are harder to quickly separate.

[nickrobinson251]

FWIW, I think the current formatting should stay as the default for a while at least. With every cosmetic change, it takes a while for the brain to get used to it and until that has happened you can't really evaluate it fairly.

Yeah, i think that's reasonable. And i think the biggest downside of the change in this PR is that it's a change at all i.e. more fidgeting about with the UI.

Just to say (as in #40228), i'm not searching for a further discussion on aesthetics, so much as trying to fix what for me is quite a significant issue with the new UI, which is that (i) some info that's very often important is printed in light_black and (ii) i can't read light_black (on my fairly standard dark theme background). So it's not so much that the appearance is new/different as that info is no longer easily visible to me. Since that's still somewhat specific to me, i'd also be happy with an option to change this only for me (but making such an option available might require a change in Base).

I'll see if i can put up another PR with a different option using ENV variables to disable colours in stacktraces.

thanks for the feedback

[nickrobinson251]

I find it easier to find the file name with the current formatting than the suggested one here because it is the only thing that is underlined.

How about if it we kept it underlined but used the more prominent color?

Apart from the downside of it being a change, i do think this solution might be nicer than e.g. #40232

Examples

[matthieugomez]

@KristofferC There is a real issue when using a dark theme (such as dark Solarized) — line numbers are almost unreadable.