Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Face eagerly when constructing StyledString #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolve Face eagerly when constructing StyledString #99

wants to merge 1 commit into from

Commits on Oct 16, 2024

  1. Resolve Face eagerly when constructing StyledString 

    This is step 1 to eliminating our type-piracy problems

StyledStrings needs to put some type that it owns into its AnnotatedStrings
so that we have a right to hook into the display logic (and the display
logic can know which copy of StyledStrings to delegate to).

It is also a semantic change to how constructing StyledStrings
behaves, but overall I think it's a lot more intuitive to have a
StyledString actually compute its style information at construction

Resolves #87
    @topolarity @tecosaur
    topolarity authored and tecosaur committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3f2a7c3 View commit details
    Browse the repository at this point in the history