Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI on old versions of Julia #20

Closed
wants to merge 1 commit into from

Conversation

LilithHafner
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #20 (69fe8a2) into main (a8a25ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files           7        7           
  Lines         799      799           
=======================================
  Hits          538      538           
  Misses        261      261           

@tecosaur
Copy link
Collaborator

I think this is for the planned 1.0 support. However, since that requires more than just an @static if VERSION < X include("compat.jl") end, we'll need a 1.0 branch and this change will need to be applied there.

@tecosaur
Copy link
Collaborator

@tecosaur
Copy link
Collaborator

tecosaur commented Nov 7, 2023

Can we close this?

@LilithHafner
Copy link
Member Author

If you're willing to accept the additional maintenance burden of having two branches to maintain instead of just one, then yes.

@tecosaur
Copy link
Collaborator

tecosaur commented Nov 7, 2023

There are some pretty major changes required for compatibility with pre-1.11 versions of Julia, so I think it makes more sense to maintain a branch.

I'm thinking that around the Julia 1.11 release, we make a StyledStrings release from that branch (say 1.0), then a release from main (1.11), and after that the branch is left as bugfix-only with future changes just going to main.

@tecosaur tecosaur deleted the lh/enable-CI-on-old-Julia branch February 1, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants