Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Allow extensions to trigger from packages in [deps] #4064

Closed
wants to merge 1 commit into from
+1 −1
Closed

[release-1.10] Allow extensions to trigger from packages in [deps] #4064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/API.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,7 @@ function precompile(ctx::Context, pkgs::Vector{PackageSpec}; internal_call::Bool
extdep_names = extdep_names isa String ? String[extdep_names] : extdep_names
for extdep_name in extdep_names
extdep_uuid = weakdeps[extdep_name]
if extdep_uuid in keys(ctx.env.manifest.deps) || Base.in_sysimage(Base.PkgId(extdep_uuid, extdep_name))
if extdep_uuid in keys(ctx.env.manifest.deps)
push!(ext_deps, Base.PkgId(extdep_uuid, extdep_name))
else
all_extdeps_available = false
Expand Down
Loading