Use K"function" for short form function AST
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
changed the title
K"function" for short form funtion ASTK"function" for short form function AST
|
looks good to me. Does it handle all 4 of these? f(x) = 10
f(x)::R = 10
f(x::T) where T = 10
f(x::T)::R where T = 10 |
Open
This is semantically incorrect and will be caught by lowering. But technically making it a parser error would be breaking :-(
This is a simple fix for the tests, but a better solution is to make Expr equivalence more permissive to accommodate having better line information in the new parser!
c42f
force-pushed
the
caf/short-form-function-head
branch
from
6eab9b6
to
6694b89
Compare
Yes! |
This form isn't a short form function definition, so should be parsed with `=` kind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #465 - see rationale there.
Fixing this turned out to be quite easy.
Compat:
Expr