Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "some warnings detected" to ParseError printing when all problems are warnings #423

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

ericphanson
Copy link
Collaborator

@ericphanson ericphanson commented Feb 25, 2024

I totally missed that the (..) issue from #350 was a warning rather than an error; I think probably bc the bold red part says ERROR: ParseError: and then the very light part says "Warning". Here I propose add to text to make it clearer by emphasizing warning vs error on the first line.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (a6f2d15) to head (4069462).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   94.61%   96.17%   +1.56%     
==========================================
  Files          14       14              
  Lines        4178     4187       +9     
==========================================
+ Hits         3953     4027      +74     
+ Misses        225      160      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c42f
Copy link
Member

c42f commented Jul 23, 2024

Do we need this for errors? It seems kind of redundant in that case.

Perhaps we just add the extra text when the error is due only to parser warnings?

src/parser_api.jl Outdated Show resolved Hide resolved
test/hooks.jl Outdated Show resolved Hide resolved
test/parser_api.jl Outdated Show resolved Hide resolved
test/parser_api.jl Outdated Show resolved Hide resolved
test/parser_api.jl Outdated Show resolved Hide resolved
test/hooks.jl Outdated Show resolved Hide resolved
@c42f
Copy link
Member

c42f commented Jul 24, 2024

@ericphanson I invited you as a collaborator on this repo (if you like) feel free to merge this when you're ready :)

@ericphanson ericphanson changed the title try to make warnings clearer add "some warnings detected" to ParseError printing when all problems are warnings Jul 24, 2024
@ericphanson ericphanson merged commit fd55088 into JuliaLang:main Jul 24, 2024
35 checks passed
@ericphanson ericphanson deleted the eph/make-warnings-clearer branch July 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants