-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "some warnings detected" to ParseError printing when all problems are warnings #423
add "some warnings detected" to ParseError printing when all problems are warnings #423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 94.61% 96.17% +1.56%
==========================================
Files 14 14
Lines 4178 4187 +9
==========================================
+ Hits 3953 4027 +74
+ Misses 225 160 -65 ☔ View full report in Codecov by Sentry. |
Do we need this for errors? It seems kind of redundant in that case. Perhaps we just add the extra text when the error is due only to parser warnings? |
@ericphanson I invited you as a collaborator on this repo (if you like) feel free to merge this when you're ready :) |
I totally missed that the
(..)
issue from #350 was a warning rather than an error; I think probably bc the bold red part saysERROR: ParseError:
and then the very light part says "Warning". Here I propose add to text to make it clearer by emphasizing warning vs error on the first line.