Add iterate method for Root objects #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. If you have any idea why the x86 tests are failing, that would be great, I'm personally quite confused. |
lbenet
reviewed
Jun 14, 2023
src/root_object.jl
Outdated
| or | ||
| - nothing: the iteration has been completed. | ||
| """ | ||
| function Base.iterate(r::Root{T}, state::Int64) where {T} |
There was a problem hiding this comment.
Thanks @edtrelo for your contribution.
Following on this comment, I think the error is due to this line: it imposes state to be Int64. I think the problem is solved if state is required to be Integer
There was a problem hiding this comment.
Thanks for the sugguestion @lbenet. I've alredy changed the type of state.
|
Sorry, I didn't notice an approval was required to run the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #180