Add dispatch to fpswhen for time-varying rate #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up version of PR 164. Adds a dispatch to fpswhen so that the rate is allowed to be a signal, instead of defining a separate function. Makes a slight change to fpswhen_connect in order to make it cover both cases.
JobJob
reviewed
Nov 23, 2017
| @@ -117,6 +117,13 @@ function fpswhen(switch, rate; name=auto_name!("$rate fpswhen", switch)) | |||
| n | |||
| end | |||
|
|
|||
| function fpswhen(switch, rate::Signal; name=auto_name!("fpswhen_rate", rate, switch)) | |||
| #Dispatch for the case where the rate is a time-varying signal. | |||
| n = Signal(Float64, 0.0, (switch,rate ,); name=name) | |||
There was a problem hiding this comment.
Having rate as a parent of n seems reasonable. I'm curious, was it needed, or you just thought it was sensible?
There was a problem hiding this comment.
The latter. I haven't tried it without rate as a parent though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up version of PR #164. Adds a dispatch to fpswhen so that the rate is allowed to be a signal, as opposed to defining a separate function in the previous PR. Makes a slight change to fpswhen_connect in order to make it cover both cases without code duplication.