Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix: Scrollbar shifts main content #3560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamsamgibbs
Copy link
Contributor

Description

This PR adds scrollbar-gutter: stable to the main content area. It reserves space for the scrollbar so it will prevent content from jumping around when the scrollbar appears / disappears. It is not fully supported, so we should be aware that this does not resolve this issue for Safari / iOS (https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter).

Testing

Set the screen size so that there is no scrollbar. Resize so that the scrollbar appears. The content should not jump around.

This branch:
https://github.com/user-attachments/assets/e3b42737-69cd-46a0-92d5-8d3848d0b209

Master:
https://github.com/user-attachments/assets/5d7e8ce7-ad9c-4678-857e-5453722e358e

Diffs

New stuff

  • Added scrollbar-gutter-stable utility class
  • Added new class to main content area

Resolves #3513

@iamsamgibbs iamsamgibbs self-assigned this Oct 30, 2024
@iamsamgibbs iamsamgibbs marked this pull request as ready for review October 30, 2024 12:30
@iamsamgibbs iamsamgibbs requested review from a team as code owners October 30, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA Dashboard: Switching team shifts the main content container
1 participant