Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Auto-expand accordions to reveal the current route #3528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Oct 29, 2024

Description

When a user is in a child menu item of the Finances area, the mobile navigation isn't expanded by default to show the active page being visited by the user. This causes confusion as nothing shows as being active in the menu and I do not know where I am, since the mobile is full screen.

This PR makes sure that the current page is highlighted.

Testing

  1. Set the view to mobile
  2. Visit the Incoming page: http://localhost:9091/planex/incoming
  3. Click the Menu button
Screenshot 2024-10-30 at 00 28 53
  1. Verify that the Finances accordion is auto-expanded and Finances is highlighted
Screenshot 2024-10-30 at 00 29 23
  1. Please do the same for the Balances page

Resolves #3505

@rumzledz rumzledz self-assigned this Oct 29, 2024
@rumzledz rumzledz marked this pull request as ready for review October 29, 2024 16:32
@rumzledz rumzledz requested review from a team as code owners October 29, 2024 16:32
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely.

Screenshot 2024-10-30 at 10 18 31 Screenshot 2024-10-30 at 10 18 48 Screenshot 2024-10-30 at 10 20 01 Screenshot 2024-10-30 at 10 20 12

And closed when loading onto other pages:
Screenshot 2024-10-30 at 10 19 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA Nav: Sub menu items not active on mobile
2 participants