New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Auto-expand accordions to reveal the current route #3528

Open

rumzledz wants to merge 1 commit into master from fix/3505-auto-expand-current-route-on-mobile

+18 −2

Contributor

rumzledz commented Oct 29, 2024 •

edited

Loading

Description

When a user is in a child menu item of the Finances area, the mobile navigation isn't expanded by default to show the active page being visited by the user. This causes confusion as nothing shows as being active in the menu and I do not know where I am, since the mobile is full screen.

This PR makes sure that the current page is highlighted.

Testing

Set the view to mobile
Visit the Incoming page: http://localhost:9091/planex/incoming
Click the Menu button

Screenshot 2024-10-30 at 00 28 53

Verify that the Finances accordion is auto-expanded and Finances is highlighted

Screenshot 2024-10-30 at 00 29 23

Please do the same for the Balances page

Resolves #3505


          fix: conditionally auto expand mobile accordion route items

4094eeb

rumzledz self-assigned this

rumzledz marked this pull request as ready for review

October 29, 2024 16:32

rumzledz requested review from a team as code owners

October 29, 2024 16:32

iamsamgibbs approved these changes

View reviewed changes

Contributor

iamsamgibbs left a comment

Working nicely.

Screenshot 2024-10-30 at 10 18 31

Screenshot 2024-10-30 at 10 18 48

Screenshot 2024-10-30 at 10 20 01

Screenshot 2024-10-30 at 10 20 12

And closed when loading onto other pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet