Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Teams Page bottom padding adjustment #3514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rumzledz
Copy link
Contributor

Description

This PR fixes the bottom padding padding for the Teams page.

Screenshot 2024-10-29 at 20 33 44

During development, I noticed that the Activity table on the Dashboard page has a redundant margin bottom so I removed it as well.

Before After
Screenshot 2024-10-29 at 20 27 30 Screenshot 2024-10-29 at 20 27 16

Testing

  1. Go to the TeamCardList.tsx file
  2. Replace line 15 with this:
// This basically just increases the team cards rendered
{[items, items, items].flat().map(({ key, ...item }) => (
  1. Visit the Teams page: http://localhost:9091/planex/teams
  2. Scroll to the very bottom of the page
  3. Verify that the team cards don't hug the bottom part of the browser viewport

Deletions ⚰️

  • Removed a redundant bottom margin for the Dashboard's Activity Table

Resolves #3489

@rumzledz rumzledz self-assigned this Oct 29, 2024
@rumzledz rumzledz marked this pull request as ready for review October 29, 2024 12:41
@rumzledz rumzledz requested review from a team as code owners October 29, 2024 12:41
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

Screenshot from 2024-10-29 18-32-58
Screenshot from 2024-10-29 18-33-03
Screenshot from 2024-10-29 18-33-10
Screenshot from 2024-10-29 18-33-22
Screenshot from 2024-10-29 18-33-30

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Looks good to me.

Screenshot 2024-10-30 at 10 06 37 Screenshot 2024-10-30 at 10 07 13

The same table fix could be applied to the main activity feed page too, but no need to do it in this PR:

Screenshot 2024-10-30 at 10 12 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Navigation] Update Teams page bottom page padding
3 participants