-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update table for mobile view #3401
base: master
Are you sure you want to change the base?
Conversation
staticSize: '180px', | ||
cell: ({ row }) => { | ||
const status = row.original.state as keyof typeof statusPillScheme; | ||
staticSize: isMobile ? '155px' : '180px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that doesn't match the design is the size, due to the fact that we have quite long statuses.
@melyndav could you please check if it is possible to leave it as it is?
Size according to design | Currently implemented |
---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rdig . I made some changes and now this table should match on both, desktop and mobile. I also added padding-bottom 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this so far, the styling is spot on:
I'm rejecting because the status sorting doesn't actually work until you sort by one of the other columns first:
Screen.Recording.2024-10-23.at.12.46.00.mov
It is also possible to sort by amount, so I'm not sure if that should be restricted so that it is not possible or whether the arrow needs to be visible here as the original issue states the reason for adding the arrow to the state field is to show that it can be sorted. Might need some input from @melyndav
15d0f7a
to
d2b63f0
Compare
Hey Sam! Thank you! Nice catch. I think we didn't have this design before with multiple arrows. I refactored a bit, and now it should work fine: I will message @melyndav regarding the Amount sorting! thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking closer now! Unfortunately I'm experiencing this weird issue with the data not sorting and the arrow direction changing on other columns. I'm not exactly sure how this is supposed to function with multiple visible arrows.
Screen.Recording.2024-10-29.at.10.44.03.mov
Thank you @iamsamgibbs for your attantion to details, I spoke to @melyndav today and it seems I misunderstood the design. Arrows will be hidden for all columns and visible for sorted ones, also on hover, you can see an arrow that means that the column is sortable 🙌 |
Description
Testing
.diff
file in your root directiongit apply .diff
Resolves #2662