fix: staking buttons, changed chart colors, indicator display, stakin… #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CzarekDryl
requested review from
TomaszChmielPagepro,
joanna-pagepro,
krawczykkatarzyna and
a team
This is needed temporarely as, until it gets supported properly in the UI, it breaks it
rdig
force-pushed
the
fix/motion-logic-fixes
branch
from
73fbbf9
to
fa8a24d
Compare
|
@CzarekDryl Hello! Could you rebase this PR, please? |
…g information text change
CzarekDryl
force-pushed
the
fix/15685033-staking-flow
branch
from
367b91f
to
d9aa63a
Compare
|
@ArmandoGraterol Done :) |
rdig
force-pushed
the
fix/motion-logic-fixes
branch
2 times, most recently
from
77f05de
to
44db006
Compare
melyndav
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Hey @CzarekDryl great work on this one! Just one issue:
- The threshold indicator doesn't hide when the user inputs an amount that passes the threshold:
|
@melyndav Raul said something else in other PR |
Closed
melyndav
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Hey @CzarekDryl just adding the comment from our clack channel so I can keep track of all the open PR's.
One requested change:
Instead of hiding the line and the text when the 10% threshold is met, can we keep everything showing and just change the text to '10% threshold met, will be made public'
rdig
force-pushed
the
fix/motion-logic-fixes
branch
2 times, most recently
from
29fe5b8
to
5529d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tw.auroracreation.com/app/tasks/15685033
https://tw.auroracreation.com/app/tasks/15649439
https://tw.auroracreation.com/app/tasks/15655944
Things that I've fixed in this PR:
Closed #1397 PR and moved styling fixes here to prevent conflicts.