Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Dashboard: Switching team shifts the main content container #3513

Open
melyndav opened this issue Oct 29, 2024 · 6 comments · May be fixed by #3560
Open

QA Dashboard: Switching team shifts the main content container #3513

melyndav opened this issue Oct 29, 2024 · 6 comments · May be fixed by #3560
Assignees
@iamsamgibbs
Labels
bug Something isn't working qa For fixes found during a qa session UI issue Minor user interface issues/ improvements

Comments

@melyndav
Copy link

Description

When selecting a team from the dashboard in the new team switcher component, the main content blocks shifts on load.

Export-1730205124136

And for inside pages:

Export-1730205251665

This appears to be only on desktop.

Steps to reproduce

  1. Log in with a MetaMask wallet
  2. On the Dashboard, select a different team using the new team switcher component.
  3. As the content loads, watch the main content container move.
    4, navigate to the teams page.
  4. Select the general team.
  5. Watch the content move on load.

Expected behaviour

  • All content globally in the main content container should not shift when a different team is selected using the new team switcher component.
@melyndav melyndav added bug Something isn't working qa For fixes found during a qa session UI issue Minor user interface issues/ improvements labels Oct 29, 2024
@iamsamgibbs
Copy link
Contributor

This is happening because the scrollbar is showing / hiding when the content exceeds the page height / when it isn't. So I'm not sure what we can do about this.

@melyndav
Copy link
Author

@iamsamgibbs is it an option to have a custom scrollbar to eliminate the jumping?

@rdig
Copy link
Member

rdig commented Oct 29, 2024

I'm really not onboard with having customized scrollbars or modifying the native scroll in any way, unless that is a design requirement

@melyndav
Copy link
Author

@rdig perfectly fine with not having a custom scrollbar. Thanks!

@arrenv
Copy link
Member

arrenv commented Oct 30, 2024

I was curious about this, as I have noticed it as well, it was something I remember solving awhile ago with some CSS trickery. Although, in doing a quick search I found this https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter which has most modern browser support now, so, could be worth adding in.

@iamsamgibbs
Copy link
Contributor

Good suggestion Arren, quickly tried this out in the inspector and looks like it would work nicely:

Screen.Recording.2024-10-30.at.10.28.28.mov

Support looks good enough that we may as well add it, with the awareness that Safari / iOS users will still experience this issue.

@iamsamgibbs iamsamgibbs self-assigned this Oct 30, 2024
@iamsamgibbs iamsamgibbs linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamsamgibbs iamsamgibbs

Labels
bug Something isn't working qa For fixes found during a qa session UI issue Minor user interface issues/ improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] Fix: Scrollbar shifts main content JoinColony/colonyCDapp
4 participants
@rdig @arrenv @iamsamgibbs @melyndav