add zsh shell path option #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Not sure if John is still merging PRs, but I appreciate the commit. Pulled it on my fork and got instantly unblocked. Thanks dude! |
|
Woah, Thank you. That's Awesome! Hopefully I hear back, otherwise I'll keep my fork up as well in case anyone else wants it! |
|
@JohnSundell could we get this PR merged? Bash doesn't handle things such as wildcard chars in file paths correctly, which zsh does handle, so at the moment I need to call out to a script which explicitly specifies zsh as its path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.