Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add dark mode variant of Logo.png #152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TimOliver
Copy link

Hi John! I'm absolutely loving Publish! Thanks so much for this project! 🙏 Here's a small repo polish PR if you're interested! 😁

I use dark mode on GitHub, and I noticed the logo in the README doesn't really 'pop' that much on a dark background.

This PR adds a light mode variant (That matches the same shade of grey as GitHub's current body text), and then adjusts the README to dynamically display the appropriate variant on page load.

I also ran pngcrush on the original logo and my dark mode variant and was able to shave 50% off the file size on both, so this change shouldn't increase the overall download size of the repo too.

Hope that helps! Thanks for the consideration!

Before

Screenshot 2024-01-21 at 12 25 07 am

After

Screenshot 2024-01-21 at 12 25 27 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant