You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 4, 2020. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Gemfile with our Ruby dependencies, updated swiftlint.yml, cause it had some issues with correctly checking files, simplified boddybuild_postclone, created very basic Dangerfile.
Hahaha, @JohnSundell you'll be the bad guy reporting all the bad things 😂 Seems like it works. I'll have to add more stuff to Dangerfile, but it's nice it works out of the box ❤️
@JohnSundell to do so I'll need access to BuddyBuild or you'll have to create Bot and add it. I have account on BuddyBuild, so I guess you can invite me, but I guess I'll be able to finish this no sooner than Tuesday (going to the wedding 👰)
@JohnSundell I'll kindly ask you to follow these steps and add the DANGER_GITHUB_API_TOKEN to Bot's build ENV. We shouldn't have any further changes in this PR as from now on buddybuild should handle everything correctly (Gemfile and Dangerfile are present).
We may wan to create a special doc for our guidelines, but I don't think it's necessary as Danger will handle everything and report it, so it's way more convenient and one less thing to maintain. I'd rather take a look at other projects and see some Danger checks for which we can benefit as well, but I guess I'll just propose them (if I find anything) in #102.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cojoj
force-pushed
the
danger
branch
4 times, most recently
from
Closes #102
Added
Gemfilewith our Ruby dependencies, updatedswiftlint.yml, cause it had some issues with correctly checking files, simplifiedboddybuild_postclone, created very basicDangerfile.