Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes AClient to work under Windows #71

Merged
merged 2 commits into from
May 28, 2019
Merged

Fixes AClient to work under Windows #71

merged 2 commits into from
May 28, 2019

Conversation

RobertBaruch
Copy link
Contributor

No description provided.

@RobertBaruch
Copy link
Contributor Author

Fixes issues: #66 , #68

@RobertBaruch
Copy link
Contributor Author

Please check that this still works under Linux.

@RobertBaruch
Copy link
Contributor Author

I confirmed that this works under Linux (VMWare instance).

@JohnDMcMaster
Copy link
Owner

Thanks for the patch! We need to test this under Linux before merging

@JohnDMcMaster
Copy link
Owner

Ooops missed that second comment, I think we are good to merge

@JohnDMcMaster
Copy link
Owner

Verified still works under Linux: "python3 examples/blinky.py"

@JohnDMcMaster JohnDMcMaster merged commit d494f32 into JohnDMcMaster:master May 28, 2019
@JohnDMcMaster
Copy link
Owner

Thanks for your patch!

@cr1901
Copy link
Collaborator

cr1901 commented May 28, 2019

I will close #66 and #68 once I can test on Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertBaruch @JohnDMcMaster @cr1901