-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging 5.4.0 #575
Merged
Merged
Staging 5.4.0 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BUG FIX: xDrip incorrectly reported +0 (or 0.0 for mmol) BG when delta was not 0 (or 0.0 for mmol) - this only occurred occasionally when BG deltas were around 1 - This fixes this issue, tested and verified on live device for mgdl
1.Added Bubble Nano support 2.Update Bubble/Bubble Mini/Bubble Nano appId
- include animations when updates are displayed or when the user double taps BG value to manually refresh data - change "last reading at xx:xx" for "x mins ago" - move connection indicator dot to info view
- add slope/minute value - add slope/5 minutes value This will help to understand why certain trend arrows are used
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.6. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.6) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…pes (single/multi-point) - algorithm and calibration types initial implementation - map boolean oopWebEnabled and nonFixedSlopeEnabled to Algorithm Type and Calibration Type enums - reverse non-fixed and oopWeb sections - clean up some of the code/logic - initial EN translations made
- i.e. when the transmitter sensor session is started by another app
ensure it is updated when a new internal sensor session is started such as after an algorithm type change
- slope/delta calculations (per min + per 5 mins) - calibration data now shown if applied to bg reading - tidy up of some existing code - initial localizations to EN
…r is first connected This prevents "No CGM Connected" from showing for newly added CGMTransmitters. This stops the UI from being incoherent whilst waiting for the first sensor readings to arrive.
- also quick Xcode structure clean-up
…SettingsViewModel Just for clarity as these settings only apply to Dexcom Share upload. Nothing else related to Dexcom
…l number in case the user leaves them blank - mainly required as it was not clear that a receiver serial number is required in order to upload data - update password obscuring to new function (as used by data source and Nightscout settings)
- transmitter battery level message (remove runtime + temp etc as not relevant any more) - hide default sensorStartDate when the transmitter sensor session is stopped (such as when a new transmitter is first connected but no sensor is yet started)
…al view controller model
initial EN and ES localizations
- watch app BigNumberView gauge scale correction - use shorter "mins ago" string when over 12 hours has passed
- update timestamp also from NightscoutUploadManager upon status 200 - change Nightscout disconnectWarning to 310 seconds (5m10s) - use abbreviated follower type name for systemSmall widget so that it fits cleanly
- mainly change "private (set)" to the correctly written "private(set)" as per Apple documentation. - add @retroactive as required (suggested by Xcode) - add the CNContactStore.authorizationStatus == .limited case to avoid warnings when building for iOS18.
- can be enabled in Settings so that the contact image renders nicely when a color tint is applied to the watchface - should be left disabled when using the usual multi-color watchface colors
- possibly the most pointless and pedantic commit in the history of the project ever :)
- remove the "show Live Activities when..." option as it made little practical sense. LA can only be started when the app is in the foreground, so start a LA and then end if automatically only when the user first opens an alarm didn't make much sense. - combine LiveActivityType and (the old LiveActivitySize) into one single enum (including disabled, minimal, normal and large) makes much more sense to operation and also to the UI. - remove LiveActivitySize
…ch app - this should prevent the "slow scrolling" of processing old userInfo values received whilst the Watch app was not active.
…iveSensor description
5.4 staging PR
Added Bubble Nano support
….3.6 Bump rexml from 3.2.8 to 3.3.6
Bug fix for false +0 (or +0.0 mmol) bg deltas
if the user has enabled the option, then update the existing contact or add a new one if it doesn't exist this isn't really the best way to do it as we should delete the contact if not required to "clean up", but too many users didn't re-select the new contact after re-enabling in the Watch complication and assumed that the app wasn't working
- this change will automatically update all existing apps with a stored version number *below* 4.12.0
Related to ##544 although the previous commits fixed the issue of erroneous (0 or close to 0) delta changes in mg/dL (the calculation was originally ported from an early xDrip+ many years ago), the mmol/L calculation has never been sufficiently accurate due to the conversion/rounding of mmol/L meaning that sometimes a +0.2mmol/L delta was actually calculated to +0.1mmol/L. This changes fixes that and also updates the calculation and string representation methods for all instances in the app, Watch, Widgets etc Also renamed a bunch of stuff to keep things constant over the whole project
add latest commits
It could happen that an internal sensor session was manually started some time after the transmitter-based session was already running. This change allows both "before and after" start date variations from the transmitter to force a new sensor session to be started with the correct (transmitter-based) start date.
This makes it clearer... the idea of a transmitter algorithm is confusing for Libre users and doesn't really explain what it is. At least for now, Native explains that the values will resemble (or be identical to) the factory algorithms in all cases. This may change in the future, but for now, it's accurate enough for the description.
- to allow for the 12 hour grace period
Since LLU 4.12.0, it seems that the server response can now sometimes return an empty activeSensor attribute. This caused xDrip4iOS to throw an error and not process downloaded data. This issue is known to affect just a handful of users and does not always happen. Sometimes the server responds correctly with all data. We'll now just treat this as optional and ignore it (and adapt/hide the UI as needed) if necessary.
G7/ONE+ has the peculiarity that it will keep sending/repeating the same BG value (without ever changing) via BLE even after the session officially ends. This change just stops processing received values after maxSensorAgeInDays is reached (10.5 days for G7/ONE+) Also updated the sensor progress colours from (gray/yellow/red and purple for expired) to (gray/yellow/orange and red for expired). This is because purple is pretty impossible to read clearly against a black background.
This will display "OFF" in the contact image if the user is in follower mode with background keep-alive disabled, or if they disable the contact image function. Also change settings text from "create contact" to "enable contact image" Add warning text to "Enable Contact Image" UISwitch if the user is in follower mode with keep-alive disabled.
initial translations of main titles/rows/messages: - en, es, nl, de, fr (no messages), sv (no messages)
Staging 5.4
This was
linked to
issues
Oct 14, 2024
translations of messages: - sv
Staging 5.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes for xDrip4iOS version 5.4.0:
Features:
Fixes: