Bug fix for false +0 (or +0.0 mmol) bg deltas #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aug0211
commented
Jun 19, 2024
•
aug0211
commented
- Address issue Erroneous +0 BG deltas reported #544
- BUG FIX: xDrip incorrectly reported +0 (or 0.0 for mmol) BG deltas when delta was not actually 0 (or 0.0 for mmol) - this only occurred occasionally when BG deltas were around 1
- This fixes this issue, tested and verified on live device for mgdl
- BUG FIX: xDrip incorrectly reported +0 (or 0.0 for mmol) BG when delta was not 0 (or 0.0 for mmol) - this only occurred occasionally when BG deltas were around 1 - This fixes this issue, tested and verified on live device for mgdl
|
Not sure about the preferred way to submit a PR, I don’t think I have access to cut a new branch in the main fork. I can target this PR to another branch if desired. |
aug0211
changed the title
|
@JohanDegraeve @paulplant wanted to bump this one for your visibility. |
|
@paulplant bump |
|
Merging into the 5.4 staging branch. There is a small logic change that I'd like to make but want to check it makes sense first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.