This repository has been archived by the owner on May 6, 2024. It is now read-only.
feat(outline/electron): ✨ expose checkConnectivity as a library function
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
force-pushed
the
junyi/clib-for-electron
branch
from
660379e
to
fda1613
Compare
jyyi1
changed the title
checkConnectivity as a library function
fortuna
suggested changes
Jan 18, 2023
| @@ -42,23 +42,33 @@ ELECTRON_PATH=$(IMPORT_PATH)/outline/electron | |||
|
|
|||
There was a problem hiding this comment.
Perhaps we should move the entire directory to /outline/internal/electron, to make it clear this code is not to be used externally.
There was a problem hiding this comment.
Same for the android and apple directories.
There was a problem hiding this comment.
Agree, I will start with the electron one first.
jyyi1
force-pushed
the
junyi/clib-for-electron
branch
from
fda1613
to
882bdf8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I exposed
checkConnectivityas a library function to be used by Outline Client electron app.Related PR: Jigsaw-Code/outline-apps#1555