Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phpstorm-stubs] update stubs to migration version for php 8.2 #1491

Draft
wants to merge 1 commit into
base: PHP_8.2
Choose a base branch
from

Conversation

isfedorov
Copy link
Contributor

No description provided.

@alies-dev
Copy link

Hey @isfedorov
thanks for insights from this PR! I'm going to apply some type changes (mostly from bool to true or false) on Psalm, but have a question for you.

I see you used true or false return types even in cases where the doc block and official PHP docs explicitly says like "true on success or false on failure". Example:

/*
 * @return true <b>TRUE</b> on success or <b>FALSE</b> on failure.
 */
function xml_set_external_entity_ref_handler(XMLParser $parser, $handler): true {}

What is the correct return type in such cases?

Thanks!

@isfedorov
Copy link
Contributor Author

@lptn please ignore this PR :) This is experimental work. Answering your question regarding return type: xml_set_external_entity_ref_handler returns only true since PHP 8.2 https://3v4l.org/fnFO5#v8.2rc7

@isfedorov isfedorov marked this pull request as draft December 3, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants