Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify resource management for iOS #3340

Merged
merged 12 commits into from
Jul 18, 2023
Merged

Simplify resource management for iOS #3340

merged 12 commits into from
Jul 18, 2023

Commits on Jul 11, 2023

  1. Simplify resource management for iOS 

    Introduces new a new task 'sync<FRAMEWORK_CLASSIFIER>ComposeIosResources',
which collects resources from all source sets, included in iOS targets.

With this change:
* CocoaPods integration does not require any configuration or calling 'pod install' after changing resources.
    * Important: existing projects need to remove 'extraSpecAttributes["resources"] = ...' from build scripts, and rerun `./gradlew podInstall` once!
* Without CocoaPods, the resource directory should be added to XCode build phases once.

Resolves #3073
Resolves #3113
Resolves #3066
    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    05342e3 View commit details
    Browse the repository at this point in the history

  2. Remove extraSpecAttributes["resources"] from examples

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    339531b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Create resources dir before podInstall

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1a80e51 View commit details
    Browse the repository at this point in the history

  2. Adjust error message

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4f6b8c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Revert extra spec resources in examples

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    965075b View commit details
    Browse the repository at this point in the history

  2. Remove duplicated provider

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a16f9d6 View commit details
    Browse the repository at this point in the history

  3. Switch :components:resources:demo to regular framework

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    dc14554 View commit details
    Browse the repository at this point in the history

  4. Replace error with warning

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9a2bfe3 View commit details
    Browse the repository at this point in the history

  5. Support subdirectories

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b5cc7d1 View commit details
    Browse the repository at this point in the history

  6. Restructure

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3d13a16 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Clear output dir

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    880c36c View commit details
    Browse the repository at this point in the history

  2. Update compose build in :resources:demo

    @AlexeyTsvetkov
    AlexeyTsvetkov committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    22d9b7c View commit details
    Browse the repository at this point in the history