-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant proof checking refactoring #46
Open
K-dizzled
wants to merge
26
commits into
v2.3.1-dev
Choose a base branch
from
core-lsp-rework
base: v2.3.1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored CoqLspClient and CoqProofChecker to use getGoals pretac to check proofs instead of manually modifying the file. ToDo: Get rid of temporary files at all, request completion only on the current document. At least in the plugin iteslf (not in benchmarks) Reference issue: JBRes-1857
Now it doesn't have a responsibility to manage opening/closing files, the outer class calling it should be responsible for it. As we have different scenarios of communication with LSP from Plugin/Becnhmark, this is still in development. Get rid of Aux files.
Now it depends on the particular chosen Ranker. It is computed iff. ranker requires unwrapped notations.
…bort Sketch aborting the completion generation through `AbortSignal`
K-dizzled
changed the title
Significant proof checking refoctoring
Significant proof checking refactoring
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version increment is minor, yet the changes are significant. The main focus of this release was to improve interaction with the
coq-lsp
server. We now completely got rid of temporary files in theextension
part ofCoqPilot
. This was done thanks to ejgallego and his improvements incoq-lsp
. Now checking of proofs is done via theproof/goals
request viacommand
parameter, which is much more reliable and faster. Now a singlelsp
server is created for the plugin until being explicitly closed, and it tracks changes in the file. If you are usingcoq-lsp
plugin itself, it will help you to always keep track of whether file is checked or not. WhenCoqPilot
is ran on a completely checked file, it will not bring any significant overhead apart from requests to the Completion Services.