Significant proof checking refactoring #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored CoqLspClient and CoqProofChecker to use getGoals pretac to check proofs instead of manually modifying the file. ToDo: Get rid of temporary files at all, request completion only on the current document. At least in the plugin iteslf (not in benchmarks) Reference issue: JBRes-1857
Now it doesn't have a responsibility to manage opening/closing files, the outer class calling it should be responsible for it. As we have different scenarios of communication with LSP from Plugin/Becnhmark, this is still in development. Get rid of Aux files.
Now it depends on the particular chosen Ranker. It is computed iff. ranker requires unwrapped notations.
…bort Sketch aborting the completion generation through `AbortSignal`
K-dizzled
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version increment is minor, yet the changes are significant. The main focus of this release was to improve interaction with the
coq-lspserver. We now completely got rid of temporary files in theextensionpart ofCoqPilot. This was done thanks to ejgallego and his improvements incoq-lsp. Now checking of proofs is done via theproof/goalsrequest viacommandparameter, which is much more reliable and faster. Now a singlelspserver is created for the plugin until being explicitly closed, and it tracks changes in the file. If you are usingcoq-lspplugin itself, it will help you to always keep track of whether file is checked or not. WhenCoqPilotis ran on a completely checked file, it will not bring any significant overhead apart from requests to the Completion Services.