Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote compilers' filepaths with "" for Windows #406

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Quote compilers' filepaths with "" for Windows #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/kotlin/org/jetbrains/research/testspark/core/test/java/JavaTestCompiler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,15 @@ class JavaTestCompiler(
override fun compileCode(path: String, projectBuildPath: String, workingDir: String): ExecutionResult {
val classPaths = "\"${getClassPaths(projectBuildPath)}\""
// compile file
// See: https://github.com/JetBrains-Research/TestSpark/issues/402
val javac = if (DataFilesUtil.isWindows()) "\"$javac\"" else "'$javac'"

val executionResult = CommandLineRunner.run(
arrayListOf(
/**
* Filepath may contain spaces, so we need to wrap it in quotes.
*/
"'$javac'",
javac,
"-cp",
classPaths,
path,
Expand Down
5 changes: 4 additions & 1 deletion core/src/main/kotlin/org/jetbrains/research/testspark/core/test/kotlin/KotlinTestCompiler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,15 @@ class KotlinTestCompiler(

val classPaths = "\"${getClassPaths(projectBuildPath)}\""
// Compile file
// See: https://github.com/JetBrains-Research/TestSpark/issues/402
val kotlinc = if (DataFilesUtil.isWindows()) "\"$kotlinc\"" else "'$kotlinc'"

val executionResult = CommandLineRunner.run(
arrayListOf(
/**
* Filepath may contain spaces, so we need to wrap it in quotes.
*/
"'$kotlinc'",
kotlinc,
"-cp",
classPaths,
path,
Expand Down
Loading