-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving Kotlin classfiles properly #392
Conversation
core/src/main/kotlin/org/jetbrains/research/testspark/core/test/kotlin/KotlinTestCompiler.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on IDEA 2024.2.3, and the problem seems to be resolved.
I got a compilation error but I think it is a local issue with my IntelliJ (version: IDEA 2024.2.3):
Having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Requires publishing a new version of the core. I see several PRs need a new major version of the core. How about merging the PRs and creating a separate PR specifically to publish a major core version at the end (for the sake of having a smaller number)? |
Description of changes made
kotlinc
saves.class
files in the same place they were called from, but we expect them to be in the same directory as source files.Probably, coverage collection for Kotlin in headless mode works now(has to be tested)
Closes #391