Command Line Runner API changes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello-zoka
added
bug
Vladislav0Art
requested changes
Oct 9, 2024
core/src/main/kotlin/org/jetbrains/research/testspark/core/utils/CommandLineRunner.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/tools/TestProcessor.kt
Outdated
Show resolved
Hide resolved
.../kotlin/org/jetbrains/research/testspark/tools/evosuite/generation/EvoSuiteProcessManager.kt
Outdated
Show resolved
Hide resolved
Hello-zoka
added
changes requested
|
@Hello-zoka I agree with Vladislav's comments, please: Then, we will check the code again. Thanks |
Hello-zoka
added
Ready for review
Vladislav0Art
approved these changes
Oct 15, 2024
...src/main/kotlin/org/jetbrains/research/testspark/core/generation/llm/LLMWithFeedbackCycle.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/research/testspark/core/utils/CommandLineRunner.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/research/testspark/core/utils/CommandLineRunner.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/tools/TestProcessor.kt
Outdated
Show resolved
Hide resolved
.../kotlin/org/jetbrains/research/testspark/tools/evosuite/generation/EvoSuiteProcessManager.kt
Outdated
Show resolved
Hide resolved
added 5 commits
October 16, 2024 00:26
# Conflicts: # core/src/main/kotlin/org/jetbrains/research/testspark/core/test/java/JavaTestCompiler.kt # core/src/main/kotlin/org/jetbrains/research/testspark/core/test/kotlin/KotlinTestCompiler.kt
…command-line-runner # Conflicts: # core/src/main/kotlin/org/jetbrains/research/testspark/core/test/TestCompiler.kt # core/src/main/kotlin/org/jetbrains/research/testspark/core/test/java/JavaTestCompiler.kt # core/src/main/kotlin/org/jetbrains/research/testspark/core/test/kotlin/KotlinTestCompiler.kt # src/main/kotlin/org/jetbrains/research/testspark/tools/TestProcessor.kt
|
Ready to merge, if there are no problems with @pderakhshanfar @arksap2002 |
pderakhshanfar
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
CommandLineRunnerwasn't returning the exit code of the execution, which made Errors/Warnings/stdout indistinguishable. This PR fixes it. Please, make sure to test it as well since it changes the core logic.Closes #298 and #361
Release
We probably don't want to include it in upcoming major releases to make sure everything works smoothly.
Notes for merging
Conflicts with PR #376