Fix execution cancellation #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arksap2002
added
bug
pderakhshanfar
approved these changes
Sep 18, 2024
Vladislav0Art
requested changes
Sep 24, 2024
There was a problem hiding this comment.
We need to start thinking about a transition to Kotlin coroutines. Although this ProgressManager-related API is marked obsolete, we still use it.
Besides, in this particular case, we could efficiently parallelize the execution of test cases if we used coroutines. Currently, we execute test cases iteratively one by one which is very slow in comparison.
Additionally, it becomes hard to manage cancellations, progress-based executions, and state updates as the project grows.
...ain/kotlin/org/jetbrains/research/testspark/display/generatedTests/TopButtonsPanelBuilder.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/org/jetbrains/research/testspark/display/generatedTests/TopButtonsPanelBuilder.kt
Outdated
Show resolved
Hide resolved
Vladislav0Art
approved these changes
Sep 30, 2024
Vladislav0Art
force-pushed
the
arksap2002/bugs/fix-excecution-cancellation
branch
from
a50a1d3
to
0220e73
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
Fix "run all" button cancellation. Checks for indicator cancellation and returns states of all remaings test cases.
Other notes
Closes #353