-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement prompt builder & make it public #292
Merged
Vladislav0Art
merged 16 commits into
development
from
vartiukhov/feature/enhance-prompt-builder
Sep 27, 2024
Merged
Re-implement prompt builder & make it public #292
Vladislav0Art
merged 16 commits into
development
from
vartiukhov/feature/enhance-prompt-builder
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladislav0Art
added
improvement
New feature
refactoring
Refactor the project
Ready for review
PR redy for review
labels
Jul 8, 2024
Vladislav0Art
added
In progress
PR is in progress
and removed
Ready for review
PR redy for review
labels
Jul 11, 2024
Make `PromptBuilder` assert that the client inserts all mandatory keywords.
This version includes all the changes of `PromptBuilder` on commit 1284ab4.
Vladislav0Art
force-pushed
the
vartiukhov/feature/enhance-prompt-builder
branch
from
September 25, 2024 15:03
15fe4ba
to
3756c8a
Compare
Vladislav0Art
requested review from
pderakhshanfar,
arksap2002 and
Hello-zoka
and removed request for
pderakhshanfar
September 25, 2024 15:03
Vladislav0Art
added
Ready for review
PR redy for review
and removed
In progress
PR is in progress
labels
Sep 25, 2024
pderakhshanfar
approved these changes
Sep 26, 2024
Hello-zoka
approved these changes
Sep 26, 2024
...src/main/kotlin/org/jetbrains/research/testspark/core/generation/llm/prompt/PromptBuilder.kt
Outdated
Show resolved
Hide resolved
Published 3.0.0 version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
New feature
In progress
PR is in progress
Ready for review
PR redy for review
refactoring
Refactor the project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
PromptBuilder
and introduce validation of the prompt keywords inserted.PromptBuilder
with unit tests.PromptBuilder
public so client code has more control over prompt generation (required by the Fleet plugin).Why is a merge request needed
core
module.PromptBuilder
in a more robust manner.Other notes
Closes #291
What is missing?
2.0.8
because previouslyPromptBuilder
was not accessible (i.e., marked asinternal
). Therefore, no client code can observe the introduced modifications toPromptBuilder
's API.3.0.0
because API ofPromptKeyword
has changed (namely,text
member field was removed).2.0.5
, which should come intodevelopment
before the current version2.0.7
.