Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement prompt builder & make it public #292

Merged
merged 16 commits into from
Sep 27, 2024

Conversation

Vladislav0Art
Copy link
Collaborator

@Vladislav0Art Vladislav0Art commented Jul 8, 2024

Description of changes made

  1. Refactor the implementation of PromptBuilder and introduce validation of the prompt keywords inserted.
  2. Cover PromptBuilder with unit tests.
  3. Make PromptBuilder public so client code has more control over prompt generation (required by the Fleet plugin).
Screenshot 2024-09-25 at 17 19 49

Why is a merge request needed

  1. Introduce unit tests for functionality from the core module.
  2. Implement PromptBuilder in a more robust manner.

Other notes

Closes #291

What is missing?

  • I need to publish a new core library version. The version should be 2.0.8 because previously PromptBuilder was not accessible (i.e., marked as internal). Therefore, no client code can observe the introduced modifications to PromptBuilder's API. 3.0.0 because API of PromptKeyword has changed (namely, text member field was removed).
  • Implement the test cases for the remaining methods.
  • Merge this branch only after this PR is merged, as the latter has a core module version changed to 2.0.5, which should come into development before the current version 2.0.7.
  • I have checked that I am merging into the correct branch

@Vladislav0Art Vladislav0Art added improvement New feature refactoring Refactor the project Ready for review PR redy for review labels Jul 8, 2024
@Vladislav0Art Vladislav0Art self-assigned this Jul 8, 2024
@Vladislav0Art Vladislav0Art added In progress PR is in progress and removed Ready for review PR redy for review labels Jul 11, 2024
@Vladislav0Art Vladislav0Art force-pushed the vartiukhov/feature/enhance-prompt-builder branch from 15fe4ba to 3756c8a Compare September 25, 2024 15:03
@Vladislav0Art Vladislav0Art added Ready for review PR redy for review and removed In progress PR is in progress labels Sep 25, 2024
@Vladislav0Art Vladislav0Art added the In progress PR is in progress label Sep 27, 2024
@Vladislav0Art
Copy link
Collaborator Author

Published 3.0.0 version of testspark-core.

@Vladislav0Art Vladislav0Art merged commit 3f0a1b3 into development Sep 27, 2024
3 checks passed
@arksap2002 arksap2002 deleted the vartiukhov/feature/enhance-prompt-builder branch October 15, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature In progress PR is in progress Ready for review PR redy for review refactoring Refactor the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement PromptBuilder & make it public
3 participants