Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Barrier Events #371

Merged
merged 14 commits into from
Oct 11, 2024
Merged

Feature: Barrier Events #371

merged 14 commits into from
Oct 11, 2024

Conversation

nathanwbrei
Copy link
Collaborator

This PR brings back barrier events definitively. Barrier events have come and gone in various forms, but hopefully this is their final form. This PR also adds a new tool for visualizing how threads are utilized, including exact event assignments and barrier events.

It also bundles in a couple of bugfixes:

  • JEventSource::FinishEvent() was being called spuriously when a JEventSourceArrow returned an (unused) JEvent to the pool after the JEventSource rejected it with FailureTryAgain
  • There was a data race in the new JLogger timestamps because, curiously, std::localtime is not threadsafe (!)
  • When populating the JParameterManager at startup, JFactory::DoInit() was silently swallowing an exception due to a null JApplication pointer.

@nathanwbrei nathanwbrei merged commit 52f140f into master Oct 11, 2024
9 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_barrier_events branch October 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant