Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to JVersion #320

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Improvements to JVersion #320

merged 6 commits into from
Jul 19, 2024

Conversation

nathanwbrei
Copy link
Collaborator

  • Feature: constexpr JVersion arithmetic
  • Feature: JPluginLoader now searches for plugins in CMAKE_INSTALL_PREFIX
  • Feature: Version description now includes install prefix and optional dependencies
  • Bugfix: stderr suppression while generating JVersion.h
  • Refactoring: Move version and splash printers out of JMain and into JVersion
  • Refactoring: Call version and splash printers from JApplication::Initialize instead of JMain

@nathanwbrei
Copy link
Collaborator Author

This completes most of the issues mentioned in #268.

  • I decided against adding a constexpr JVersion(int,int,int) constructor with overloaded comparison operators because JVersion is much richer than a 3-tuple of ints, and because it would have exactly the same power as doing JVersion::GetVersionNumber() < 2'003'001 but with a whole lot more complexity.

  • Checking the version number when loading plugins is really more a JPluginLoader problem, so I'll add it to the list of JPluginLoader problems and tackle them together. The plugin loader is tricky to modify because it has lots of finicky details and doesn't lend itself well to unit testing.

@nathanwbrei nathanwbrei merged commit c7be03a into master Jul 19, 2024
3 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_jversion_improvements branch July 19, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant