Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing yabaiPath bug. #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toastsandwich
Copy link

@toastsandwich toastsandwich commented Sep 20, 2024

Description

Fix for issue #401
This is the bug where yabaiPath is being over ridden, so its separated from the const group.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

  • OS version [e.g. Sonoma 14.1.1]

  • Yabai version [e.g. yabai-v6.0.1] (output of yabai --version)

  • Übersicht version [e.g. Version 1.6 (82)]

@toastsandwich
Copy link
Author

Hey @Jean-Tinland, this pr solves the issue for overriding of yabai path

@Jean-Tinland
Copy link
Owner

Hi, thanks for your contribution but this will maybe solve this specific problem but it will also remove the ability to change the yabai path from simple-bar settings.

I'm not sure why you need to modify this as the path is customizable from simple-bar settings. This value is simple a default value in case the users completely removes the path in the settings.

@toastsandwich
Copy link
Author

toastsandwich commented Sep 25, 2024

Ok so @Jean-Tinland when i had configured simple bar i got the error as "something went wrong..." upon researching there was issue raised regarding the same, and had solution provided, and recently also new issue was opened. So what i am thinking is yabaiPath must be overridden by settings.Global. So by taking it out, it starts working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants