Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Animated Java to v1.5.2 #638

Merged
merged 4 commits into from
Nov 3, 2024

Conversation

@SnaveSutit SnaveSutit changed the title Update Animated Java to v1.5.0 Update Animated Java to v1.5.1 Oct 23, 2024
@JannisX11
Copy link
Owner

plugins.json entry has some missing fields. At least variant: desktop is required for this plugin, tags are probably also not intentionally removed.
What changed in 1.5? It looks like the changelog that is linked is incomplete.

@SnaveSutit
Copy link
Contributor Author

Ah, looks like I incorrectly edited 1.5.0's changelog when trying to make 1.5.1's changelog. I've fixed that issue

@SnaveSutit
Copy link
Contributor Author

I implemented a new build script that automatically copies over all changed values, but apparently I had missed version and tags.
Those should be back now.

@JannisX11
Copy link
Owner

Min_version is still missing, without it Blockbench would assume it's a legacy version and try to load the plugin from plugins/animated_java.js.
I also noticed some error messages when installing the plugin for the first time:
image

@SnaveSutit
Copy link
Contributor Author

I've fixed the download issue by switching download APIs, and updated min_version. I had min_blockbench_version in my package, but was looking for min_version, so it was defaulting to undefined.

@SnaveSutit SnaveSutit changed the title Update Animated Java to v1.5.1 Update Animated Java to v1.5.2 Nov 2, 2024
@JannisX11 JannisX11 merged commit 674b175 into JannisX11:master Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants