-
Notifications
You must be signed in to change notification settings - Fork 59
add test suite and fixes #3 #14
base: master
Are you sure you want to change the base?
Conversation
I hope I have time to review this soon, very low bandwith this week. |
Haha, it's fine, take it easy :). |
Happy festival to you 😊
|
I'm not a big fan of gulp, I replaced all grunt / gulp tasks with npm scripts inside my projects. Could you think of making several webpack.config and calling those in command line, making scripts for mock server, test runner, cleaning. Also files created for test purpose should be in a different folder than Same for coverage, coveralls can be used in CLI, no need for gulp for that. |
No problem.Your repo, your rule:smile:.I will update it. |
Thank you @yeyu456 your help is really appreciated! |
@JSteunou already finished.You can review now.remove all the gulp and use purely node script. |
Except the test files, adding some dev dependencies package for testing.
Using mocha, chai, karma with some plugins as test framework.
And using the gulp for tasks like creating a mock server and the code coverage.
Libraries like core-js, sockjs and sockjs-client are make sure the browser compatibility test pass.