Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

add test suite and fixes #3 #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add test suite and fixes #3 #14

wants to merge 4 commits into from

Conversation

yeyu456
Copy link
Contributor

@yeyu456 yeyu456 commented Jun 9, 2016

Except the test files, adding some dev dependencies package for testing.
Using mocha, chai, karma with some plugins as test framework.
And using the gulp for tasks like creating a mock server and the code coverage.
Libraries like core-js, sockjs and sockjs-client are make sure the browser compatibility test pass.

@JSteunou
Copy link
Owner

JSteunou commented Jun 9, 2016

I hope I have time to review this soon, very low bandwith this week.

@yeyu456
Copy link
Contributor Author

yeyu456 commented Jun 9, 2016

Haha, it's fine, take it easy :).
And Happy Dragon Boat Festival today.

@JSteunou
Copy link
Owner

JSteunou commented Jun 9, 2016

Happy festival to you 😊
Le 9 juin 2016 13:19, "yuye" [email protected] a écrit :

Haha, it's fine, take it easy :).
And Happy Dragon Boat Festival today.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACNytygR0JbyTwagAuw11yd5XksRskrkks5qJ_a_gaJpZM4Ix08g
.

@JSteunou
Copy link
Owner

I'm not a big fan of gulp, I replaced all grunt / gulp tasks with npm scripts inside my projects. Could you think of making several webpack.config and calling those in command line, making scripts for mock server, test runner, cleaning. Also files created for test purpose should be in a different folder than dist/, I prefer leaving it untouched except for each new release. Maybe a folder inside test/ or a tmp/ folder.

Same for coverage, coveralls can be used in CLI, no need for gulp for that.

@yeyu456
Copy link
Contributor Author

yeyu456 commented Jun 12, 2016

No problem.Your repo, your rule:smile:.I will update it.

@JSteunou
Copy link
Owner

Thank you @yeyu456 your help is really appreciated!

@yeyu456
Copy link
Contributor Author

yeyu456 commented Jun 14, 2016

@JSteunou already finished.You can review now.remove all the gulp and use purely node script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants