Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of comprehensive test, hotfix on clear text #79

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Start of comprehensive test, hotfix on clear text #79

merged 3 commits into from
Sep 27, 2023

Conversation

klxu03
Copy link
Collaborator

@klxu03 klxu03 commented Sep 26, 2023

No description provided.

@danyaljj
Copy link
Member

Did you mean to include src/comprehensive_test.py inside the CI workflows?

https://github.com/JHU-CLSP/turk-instructions/blob/main/.github/workflows/ci.yml#L53

@klxu03
Copy link
Collaborator Author

klxu03 commented Sep 26, 2023

Did you mean to include src/comprehensive_test.py inside the CI workflows?

https://github.com/JHU-CLSP/turk-instructions/blob/main/.github/workflows/ci.yml#L53

Not with our CI testing for each PR. After I finish I might link it up to a GitHub action we can manually trigger whenever and maybe do it every two days or something just as a general health diagnostic. Though this behavior is still undetermined atm

@@ -706,6 +704,46 @@ def enumerate_tasks(self, max_instance_count: int):
print("----------------------------------------------")
print(f'Field statistics per task: {task_field_statistics}')

def enumerate_comprehensive_tests(self, max_instance_count: int):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where you call this function.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this function isn't being called right now, still a wip. that's a stub, small progress. this PR was mostly for the clear_text fix for my Mac devices in case a mac user wanted to run tests locally and continually fails the HTER task

@danyaljj danyaljj merged commit 3d3b238 into main Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants