Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author In-Group Analysis Phrase Classification 2 Resolved #70

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Author In-Group Analysis Phrase Classification 2 Resolved #70

merged 3 commits into from
Sep 14, 2023

Conversation

klxu03
Copy link
Collaborator

@klxu03 klxu03 commented Sep 14, 2023

There was indeed an issue with the batch.csv Answer headers having an excess .on appended to the end compared to the name in the input which is just "10" for example instead of "10.on".

There were two solutions that came to mind: substringing it and just taking values before the second dot, or just modifying the batch.csv. I ended doing the latter since having dots are technically valid for the name attribute.

@danyaljj

Copy link
Member

@danyaljj danyaljj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@danyaljj danyaljj merged commit 9b02ab9 into JHU-CLSP:main Sep 14, 2023
1 check passed
@danyaljj
Copy link
Member

FYI @yeganehkordi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author In-Group Analysis Phrase Classification 2 batch.csv file headers say .on which messes up our code
2 participants