Got project working locally on my Mac #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already exists instead of forcing its deletion
danyaljj
reviewed
Sep 13, 2023
|
Looks good to me except the issue with headless+chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the project working locally on my Mac.
Updated Selenium to version 4.12.0 for Chrome compatibility since my Chrome is version 116, for newer versions past 115 need an updated version of Selenium past 4.11.0.
Changed src/1_run_website.sh to allow for my package manager tea python and pip. In addition, I modified the expected behavior if the Turkle directory already exists to simply run the Turkle server and exit instead of exiting with an error and forcing user to delete the directory.
Patched minor issues in 4_run_evaluation.py with unknown args errors fixed with this SO post.