Add github CLI to global-workflow-env

[eap]

Add the github-cli to global-workflow-env

Testing

• Using an unsubmitted comparison shell tool (coming soon) I compared the spack lock files of the unified-dev environment before and after addition of the gh command line tool to the template. No dependences are added or changed (other than gh) in order to include this CLI tool
• I built and ran this code on an ubuntu 22.04 host in the unified-dev environment.

Issue(s) addressed

Fixes: #1105

Checklist

• This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
• These changes have been tested on the affected systems and applications.
• All dependency PRs/issues have been resolved and this PR can be merged.

[climbfuji]

I noticed CI is failing, can you check please?

Also, I am torn. We should check the original issue, and if the users requesting gh cli want it for a specific application (e.g. global workflow), then it should either go in that virtual package or higher up in the tree if more applications want it.

The goal is to be able to load a single module (after the stack-* metamodules) such as module load global-workflow-env and having access to everything that is needed. Users shouldn't have to know all dependencies themselves, that's our job.

[climbfuji]

It seems like the permissions in the extracted gh cli source code are causing other PR's github actions to fail:

https://github.com/JCSDA/spack-stack/actions/runs/10526384237/job/29167119508?pr=1257

I'll remove the build caches manually on the systems for now so that #1257 can proceed, please fix this before pushing to the branch again:

rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/cyberphone: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/example_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/errors_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/LICENSE: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/format_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/Makefile: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/go113_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/README.md: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/json_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/appveyor.yml: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/.gitignore: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/stack.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/stack_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/go113.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/bench_test.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/.travis.yml: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]/errors.go: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg/[email protected]: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/pkg: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg: Permission denied
rm: cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q: Permission denied

[climbfuji]

Looks like all the offending files are missing the write permission:

ip-10-0-0-117:spack-stack ec2-user$ ls -la cache/build_stage/spack-stage-gh-2.50.0-gmwttfxsdsroeb4d6wsgtl66ydnxo26q/pkg/mod/github.com/cyberphone
total 0
drwxr-xr-x   3 ec2-user  staff    96 Aug 23 04:33 .
drwxr-xr-x  79 ec2-user  staff  2528 Aug 23 04:33 ..
dr-xr-xr-x  16 ec2-user  staff   512 Aug 23 04:33 [email protected]

[eap]

Thanks for the review - I've updated this per your suggestion; I'm still learning the various enviornment modules we manage. I'll watch the workflow results here to see if that CI fix we merged works as expected.

[climbfuji]

Looks good to me, thanks for making the updates. I'll go ahead and approve. Auto-merge will take care of the rest, assuming that the tests all pass.

[climbfuji]

I see that the ubuntu intel CI test fails because of go. We should stay away from go. That's the reason why git-lfs is always an external package. go is difficult to build, if we can avoid it then let's do it. If not, we need to look into building go with GNU (along the lines of #1257

Withdrawing my approval because I didn't realize that gh cli depends on "go" - need to take a closer look at the package