cardano-testnet | Add verification check in stake registration/deregistration test #6026
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/test/add-checks-for-stake-regi-deregistration-test
branch
from
6e2dd65
to
b3ffe47
Compare
9 tasks
carbolymer
force-pushed
the
mgalazyn/test/add-checks-for-stake-regi-deregistration-test
branch
from
b3ffe47
to
eb09bcf
Compare
smelc
approved these changes
Oct 30, 2024
Comment on lines
+607
to
+609
| . L.dsUnifiedL | ||
|
|
||
| pure $ L.toStakeCredentials pools |
There was a problem hiding this comment.
Suggested change
| . L.dsUnifiedL | |
| pure $ L.toStakeCredentials pools | |
| . L.dsUnifiedL | |
| pure $ L.toStakeCredentials pools |
Rationale: being a challenger in nitpick of the year category 😆
There was a problem hiding this comment.
do we have a leaderbard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks if the staking address was registered in the ledger.
Follow-up from:
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.