Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created development setup script (including docs) #9

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

jaenrig-ifx
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Copy link
Member

@ederjc ederjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look beautiful 👍
Dev script seen but not tested.

Copy link
Collaborator

@ramya-subramanyam ramya-subramanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice descriptions! Just a few comments


5. Change directories::
Ramya: I think we can skip this one, as the contributors should start with the .json package index installation available or?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can skip this. I mainly added this step for us. But not needed anymore. We should start with package index installation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Technically, we could even have a script that also take cares of all these steps. Like quick-start-dev: Installing arduino-cli if not available, check the path is the default installation path, then clone the repo in the right... then run the git submodules + sym links.
But that would be maybe a improvement for later or?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment removed.

cd packages/Infineon-psoc/hardware/psoc

..
TODO: We already have the "Infineon" package (from XMC-for-Arduino). We should go for "infineon" instead of "infineon-psoc". And
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was also thinking that. But the problem is when both xmc and psoc needs to be installed, we should check if the package index json will get replaced or extended.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have to check that. Arduino has cores in different repos (and they all end up under /packages/arduino, but I think only one json file. I guess it should work if splitted in different jsons?
Easy to check anyhow :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am preparing a new release and once we have it we can check this


cd packages/Infineon-psoc/hardware/psoc/<x.y.z>

5. Change directories
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the step number 3 and 4 missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upp sorry! Fixed 🐛


cd cores/psoc

6. Copy or symlink the ``api`` folder from the ArduinoCore-API submodule
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add another manual step before this symlinking point to checkout the arduino-core-api inside the extras folder? or Is it done with submodule init command (Is this done automatically or manually)?

@@ -17,7 +19,7 @@ Paste the following URL into the *Additional boards manager URLs* input field un

::

https://github.com/Infineon/arduino-core-psoc/releases/latest/download/package_infineon_index.json
https://github.com/Infineon/arduino-core-psoc/releases/latest/download/package_psoc_index.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to rename this package_infineon_index to package_psoc_index?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we cannot have the same name for both xmc-for-arduino and arduino-core-psoc... But I am not sure.
So i would say we name it only as psoc, and maybe at one point the other is named after xmc or?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can try that

docs/development-instructions.rst Outdated Show resolved Hide resolved

cd packages/Infineon-psoc/hardware/psoc/0.0.1
0. Obviously |:neutral_face:|, install `Arduino IDE (2.0 or higher) <https://docs.arduino.cc/software/ide-v2/tutorials/getting-started/ide-v2-downloading-and-installing/>`_ or `Arduino CLI (1.0.0 or higher) <https://arduino.github.io/arduino-cli/0.24/installation/>`_.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty line between 0 and 1 would look good. But not sure if this will appear in the readthedocs page. There is an empty line between 7 and 8 but is not showing in the page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that is because of the comments I inserted there, but we will remove some of them, as we get all those things clear.

@jaenrig-ifx jaenrig-ifx force-pushed the api-setup branch 4 times, most recently from 64ef407 to d83d9e9 Compare September 24, 2024 08:12

cd packages/Infineon-psoc/hardware/psoc/<x.y.z>

3. 0. Initialize the ArduinoCore-API submodule
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to just remove one "0." here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! Sorry :)

@ramya-subramanyam ramya-subramanyam merged commit 0dd5587 into develop Sep 25, 2024
2 checks passed
@ramya-subramanyam ramya-subramanyam deleted the api-setup branch September 25, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants