Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use ACA-Py 0.9.0 #40

Closed
wants to merge 13 commits into from
Closed

Update tests to use ACA-Py 0.9.0 #40

wants to merge 13 commits into from

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Jul 21, 2023

No description provided.

dbluhm and others added 5 commits July 21, 2023 15:44
@dbluhm
Copy link
Member Author

dbluhm commented Aug 15, 2023 •
edited
Loading

Code quality check needs to be bumped from 3.6 to 3.9 (can also bump the runner to ubuntu-latest at the same time). Re: timeouts, we would need to adjust the timeouts on the record_with_value calls which is actually happening in the protocols methods we're calling, I think. We'd need to update the acapy-minimal-example controller to allow us to set a default timeout. Might be best to save that for another day. (Feel like opening a ticket on the AME repo for that? 🙂)

@anwalker293
Copy link
Contributor

Sure! You've got it! (I'm assuming undo the timeouts I changed then, right? (whoops))

anwalker293 and others added 7 commits August 15, 2023 21:44
@anwalker293
fix: v3 not v4 for code-quality-check
a4ada6f 
Signed-off-by: Alex Walker <[email protected]>
@anwalker293
Revert "fix: increase timeout to 10s"
aa83e24 
This reverts commit db353a4.
@anwalker293
fix: update poetry lock
49ff66a 
Signed-off-by: Alex Walker <[email protected]>
@dbluhm
fix: mediation record issues
92ede15 
Mediation record model upstream doesn't match what's actually coming
back from webhooks right now.

Signed-off-by: Daniel Bluhm <[email protected]>
@anwalker293
chore: run on ubuntu-latest
0d77217 
Signed-off-by: Alex Walker <[email protected]>
@anwalker293
chore: run on ubuntu-latest
308e337 
Signed-off-by: Alex Walker <[email protected]>
@anwalker293
chore: run on ubuntu-latest
1397566 
Signed-off-by: Alex Walker <[email protected]>
@anwalker293
Copy link
Contributor

🎉

@anwalker293 anwalker293 marked this pull request as ready for review August 17, 2023 21:07
@dbluhm
Copy link
Member Author

dbluhm commented Sep 7, 2023

Superseded by #41; thanks!

@dbluhm dbluhm closed this Sep 7, 2023
@dbluhm dbluhm deleted the chore/acapy-0.9.0-rc0 branch September 7, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjhowland cjhowland Awaiting requested review from cjhowland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbluhm @anwalker293