Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proved QHat.rat_meet_zHat and QHat.rat_join_zHat. #161

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Proved QHat.rat_meet_zHat and QHat.rat_join_zHat. #161

wants to merge 8 commits into from
+56 −44

Conversation

DjangoPeeters
Copy link

@DjangoPeeters DjangoPeeters commented Oct 4, 2024 •
edited
Loading

Proved QHat.rat_meet_zHat and QHat.rat_join_zHat.

@DjangoPeeters DjangoPeeters changed the title Proved QHat.rat_meet_zHat Proved QHat.rat_meet_zHat and QHat.rat_join_zHat. Oct 5, 2024
Ruben-VandeVelde
Ruben-VandeVelde reviewed Oct 5, 2024
View reviewed changes
Copy link
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but since you asked for feedback, here's some things I might change. Please don't let the wall of text demotivate you; I'm just hoping you might find my suggestions interesting.

FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
FLT/AutomorphicRepresentation/Example.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde
Copy link
Contributor

And please also add \leanok after \begin{proof} for both lemmas in blueprint/src/chapter/ch05automorphicformexample.tex

@DjangoPeeters
Copy link
Author

Done.

@DjangoPeeters
Copy link
Author

Ruben, I think your 2nd lemma gave an error...

@kbuzzard
Copy link
Collaborator

Thanks a lot for your work on this! Can you resolve the issues which have been dealt with so I can see what's going on? Sorry, I've been dealing with real life for most of this week but now I've got more time for FLT.

@DjangoPeeters
Copy link
Author

I'll first check if the lean and mathlib versions are compatible.

@DjangoPeeters
Copy link
Author

Seems like my local lean version is v4.12.0 and this repo is using v4.13.0-rc3.

@DjangoPeeters
Copy link
Author

DjangoPeeters commented Oct 11, 2024 •
edited
Loading

Hmm, something about failed to synthesize RingHomClass blah. I think it is not converting the algebra morphism to a ring homomorphism in the proof of lemma _root_.Algebra.TensorProduct.one_tmul_intCast. Idk how I need to solve that right now, but I'll try using @.

@DjangoPeeters DjangoPeeters marked this pull request as draft October 11, 2024 18:29
@DjangoPeeters
Copy link
Author

DjangoPeeters commented Oct 11, 2024 •
edited
Loading

Due to the mathlib bump, FunLike was split and I think I need AlgHom.funLike but due to a signature change it's gonna take me some more time fixing this...

@DjangoPeeters
Copy link
Author

It seems I have fixed it.

@DjangoPeeters DjangoPeeters marked this pull request as ready for review October 13, 2024 10:06
@pitmonticone
Copy link
Collaborator

Just resolved a small merge conflict.

@kbuzzard
Copy link
Collaborator

It seems I have fixed it.

There are many unresolved conversations. Can you resolve those which are now dealt with? Then it will be easier to see what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbuzzard kbuzzard kbuzzard left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DjangoPeeters @Ruben-VandeVelde @kbuzzard @pitmonticone