Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jhbuild: build gstreamer plugin 'dav1ddec' #44

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dpino
Copy link
Member

@dpino dpino commented Sep 11, 2024

@dpino dpino force-pushed the jhbuild-build-gstreamer-dav1ddec branch from 4529db9 to 19374fe Compare September 13, 2024 09:57
@dpino
Copy link
Member Author

dpino commented Sep 13, 2024

It seems that even after building dav1d, making it a dependency of gstreamer and enable rust plugins, the plugin dav1ddev is not present.

Examining the GitHub's CI build logs, I can see gst-plugins-rs skips the compilation of dav1d plugin.

This is from my previous build attempt:

2024-09-11T14:26:34.6970504Z gst-plugins-rs| Dependency dav1d found: NO found 1.4.1 but need: '<1.3' ; matched: '>=1.0'

That condition comes from:

I'm not sure what the condition <1.3 means to refer to.

@philn Do you have any idea about what might be issue?

@philn
Copy link
Member

philn commented Sep 13, 2024

The issue is that the gst-plugins-rs.wrap from the gstreamer 1.24 branch points to gst-plugins-rs 0.12:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/1.24/subprojects/gst-plugins-rs.wrap

What we want is 0.13. So for now (until 1.26 is released i suppose) i would recommend to build gst-plugins-rs separately, eg. not as a subproject.

@dpino dpino force-pushed the jhbuild-build-gstreamer-dav1ddec branch from 19374fe to a89dcf5 Compare September 13, 2024 13:43
@dpino
Copy link
Member Author

dpino commented Sep 13, 2024

The issue is that the gst-plugins-rs.wrap from the gstreamer 1.24 branch points to gst-plugins-rs 0.12: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/1.24/subprojects/gst-plugins-rs.wrap

What we want is 0.13. So for now (until 1.26 is released i suppose) i would recommend to build gst-plugins-rs separately, eg. not as a subproject.

Thanks for the explanation. This information was very useful.

@dpino dpino force-pushed the jhbuild-build-gstreamer-dav1ddec branch from a89dcf5 to 4aee20c Compare September 13, 2024 14:35
@dpino dpino force-pushed the jhbuild-build-gstreamer-dav1ddec branch from 4aee20c to abdf115 Compare September 15, 2024 10:38
@dpino dpino force-pushed the jhbuild-build-gstreamer-dav1ddec branch from abdf115 to 466b5bb Compare September 30, 2024 08:23
@dpino dpino force-pushed the jhbuild-build-gstreamer-dav1ddec branch from 466b5bb to 1b4f049 Compare October 25, 2024 10:09
@dpino dpino merged commit 637a126 into main Oct 25, 2024
2 checks passed
@dpino dpino deleted the jhbuild-build-gstreamer-dav1ddec branch October 25, 2024 10:54
@dpino dpino self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants