wl: Only use xdg-decoration if it's supported by the compositor #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI suggests some minor code style changes, otherwise LGTM. |
auto-merge was automatically disabled
June 13, 2024 22:43
Head branch was pushed to by a user without write access
mnme
force-pushed
the
xdg-decoration-safeguard
branch
from
426b10b
to
d0fe7e8
Compare
|
Thanks, I amended the necessary changes. Already thought the line has gotten a bit long, good to know you have a style checker script. Might be worth to mention that in the contribution guide. |
TingPing
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the xdg-compositor protocol on a compositor that doesn't support it produces a segfault. Guard against this.