core, wl: Factor out view fullscreening #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
requested review from
TingPing,
alexgcastro,
csaavedra and
carlosgcampos
aperezdc
force-pushed
the
aperezdc/view-toggle-fullscreen
branch
from
e9265c7
to
60463fc
Compare
Move view fullscreening to new vfuncs in the CogView class, which get in turn implemented by CogWlView. This moves the entry point to common code, which would allow other platform plug-ins to implement the functionality if desired. Also, handling its key binding can be moved along to common code.
aperezdc
force-pushed
the
aperezdc/view-toggle-fullscreen
branch
from
60463fc
to
c14f86a
Compare
|
Ping reviewers 🏓 |
csaavedra
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move view fullscreening to a new vfunc in the
CogViewclass, which gets in turn implemented byCogWlView. This moves the entry point to common code, which would allow other platform plug-ins to implement the functionality if desired. Also, handling its key binding can be moved along to common code.