Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wl: Fix the validation of the exported image in outputs with scale factor #637

Merged
merged 2 commits into from
Oct 31, 2023
Merged

wl: Fix the validation of the exported image in outputs with scale factor #637

merged 2 commits into from
Oct 31, 2023

Commits on Oct 30, 2023

  1. wl: Fix the validation of the exported image in outputs with scale fa… 

    …ctor

The patch fixes a basic logic bug inside of the on_export_wl_egl_image().
The error is in the incorrect use of scale_factor (actually defined for the
WebPage zooming) instead of the current_output->scale for validating the
exported image geometry.

The change also unifies inside of the new validate_exported_geometry()
function the shared code used for validating the sizes of the exported images.

This fixes regression added in e533fce.

Thanks to Adrian Perez de Castro <[email protected]> for reporting the issue.
    @psaavedra
    psaavedra committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d212403 View commit details
    Browse the repository at this point in the history

  2. wl: Force a View resize on the output changed 

    The device scale factor could be different and the scale of the exported
image should be also updated.
    @psaavedra
    psaavedra committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a39d663 View commit details
    Browse the repository at this point in the history